-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up non-functional CloudEvents Metrics in Reconciler for Deprecated CloudEvents #6827
Conversation
557d1ca
to
1e0a7d8
Compare
This commit cleans up the CloudEvents Metrics which are no longer functional with the removal of CloudEvents PipelineResources, and also the CloudEvents field of the TaskRun Status API is also deprecated and not moved to v1.
1e0a7d8
to
cdc9134
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/assign @afrittoli @dibyom @lbernick |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm I think we could also remove some of the unused cloudevents code: pipeline/pkg/reconciler/events/cloudevent/cloud_event_controller.go Lines 38 to 52 in f0f5646
|
Agreed! as put at #6826 (comment), this current PR is opened to unblock v1 swap and as pointed these could also be removed in a followup PR. |
/retest |
|
/test pull-tekton-pipeline-alpha-integration-tests |
/test pull-tekton-pipeline-alpha-integration-tests |
CloudEvent metrics was removed as part of pr tektoncd#6827 . We removed this from documentation also.
CloudEvent metrics was removed as part of pr #6827 . We removed this from documentation also.
Changes
This commit cleans up the CloudEvents Metrics which are no longer functional with the removal of CloudEvents PipelineResources, and also the CloudEvents field of the TaskRun Status API is also deprecated and not moved to v1.
/kind cleanup
fixes: #6826
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes